Review requested:

• @nodejs/http2
• @nodejs/net
• @nodejs/security-wg

CI: https://ci.nodejs.org/job/node-test-pull-request/72307/

CI: https://ci.nodejs.org/job/node-test-pull-request/72318/

CI: https://ci.nodejs.org/job/node-test-pull-request/72325/

This requires reverting a change was causes CI failures

Example revert in previous PR: 1ab2794

@trivikr I'm lost.

The commit nghttp2/nghttp2@7784fa9 published in nghttp@1.67.0 have been breaking CI tests in Node.js

Antoine documented it in #60661, and we've been reverting that commit when upgrading nghttp2.
An example revert from previous PR 1ab2794

I'm going to look into the upstream nghttp2 issue here and see if I can find a proper solution, watch this space.

EDIT: See nghttp2/nghttp2#2604 (comment)

Unless those can be fixed/reverted upstream, we would have to update the test.

The commit nghttp2/nghttp2@7784fa9 published in nghttp@1.67.0 have been breaking CI tests in Node.js

Antoine documented it in #60661, and we've been reverting that commit when upgrading nghttp2. An example revert from previous PR 1ab2794

This is unreasonable on downstreams using unbundled nghttp2. Please just fix the code here - your tests are failing for a reason.

This is unreasonable on downstreams using unbundled nghttp2. Please just fix the code here - your tests are failing for a reason.

Hi @Kangie - I appreciate the input and challenges here, but that's not so simple. This is an actual incompatibility that creates breaking changes in Node.js http2 when using nghttp2 1.67 & 1.68. I'm not sure how you can best manage this in unbundled environments, but we can't include unexpected breaking changes like that in official releases.

Fortunately, there's been more discussion in nghttp2/nghttp2#2604, and the key nghttp2 changes have now been reverted in 1.69. For some other remaining changes we'll still need updates here in Node.js to release, but more limited in scope.

nghttp2 1.69.0 was just released yesterday with this, I'm aiming to test & integrate that today or tomorrow to resolve this and open a new PR. I'll update here once there's progress.